Conversation
| if (value != null) { | ||
| finalAttributes[key] = value.toString() | ||
| } |
There was a problem hiding this comment.
Good catch @jamesnrokt . One question - In MP, we can set an attribute directly to be null using these user tags. In the example on our docs, https://docs.mparticle.com/developers/client-sdks/android/users/#set-user-tags, it uses platinum_member: NULL as the example.
In Rokt, is null not a valid value, and so we skip the setting of those attributes, as opposed to having the option to set them as null?
There was a problem hiding this comment.
Can you also add a test for passing a null value?
There was a problem hiding this comment.
Added a test for passing in a null value
I believe Rokt doesn't use null values. For something like platinum_member we'd do key value "membershipLevel": "platinum"
rmi22186
left a comment
rmi22186
left a comment
There was a problem hiding this comment.
LGTM - just failing a check due to the workflow not being updated to permit PR-ing to main, but no big deal.
|
Thanks Rob
Already have a PR in place for that check: mParticle/mparticle-workflows#88 |
2 participants
Instructions
Attempt to invoke virtual method 'java.lang.String java.lang.Object.toString()' on a null object referenceSummary
Testing Plan
Reference Issue (For mParticle employees only. Ignore if you are an outside contributor)